Re: ANN: TileQt version 0.1

Georgios Petasis schrieb:
> [26 Feb 2006]
>
> ANNOUNCE: TileQt, version 0.1
>
> This is the first release of TileQt! Although a first attempt,
> TileQt supports most of the tile widgets quite well, and is
> stable (i.e. no XErrors or crashes).
>

George,

It is great to see that TileQt is being actively maintained. I have
taken a look at this release, and I would like to draw your attention to
a few aspects that I found in the code:

1. The -buttonbackground and -buttonforeground options of the
tile::theme::tileqt::currentThemeColour command return the same values
as the -background and -foreground options, because they call the same
methods (background() and foreground()) of the active palette. I don't
think this is correct: These options should invoke the button() and
buttonText() methods instead.

2. I am missing currentThemeColour options like -windowbackground and
-windowforeground, corresponding to the windowBackground and
windowForeground items in the *.kcsrc files describing the color
schemes. These should return the colors obtained by calling
qApp->palette().active().base() and qApp->palette().active().text().

3. Currently the background and foreground colors of disabled widgets
are the same as those of the widgets in normal state. This should be
changed in a subsequent release, and the currentThemeColour command
should also have options for retrieving the colors corresponding to the
disabled state.

Thanks for all your work put into this really nice and important extension.

Best regards,
Csaba

-- 
Csaba Nemethi   http://www.nemethi.de   mailto:csaba.nemethi@t-online.de